[DO NO MERGE] test gas report #35
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
contracts/OwnerData.sol
Outdated
| error InvalidSignature(); | ||
|
|
||
|
|
||
| constructor(address signer_, address serviceFeeReceiver_, uint256 serviceFee_) { |
There was a problem hiding this comment.
Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
tienngovan
force-pushed
the
ci/test-gas-report
branch
5 times, most recently
from
a2e31a1
to
ce1899c
Compare
tienngovan
force-pushed
the
ci/test-gas-report
branch
from
90602db
to
1b2a055
Compare
contracts/OwnerData.sol
Outdated
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.13; | ||
|
|
||
| import "@openzeppelin/contracts/utils/Context.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/utils/Context.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/OwnerData.sol
Outdated
| pragma solidity ^0.8.13; | ||
|
|
||
| import "@openzeppelin/contracts/utils/Context.sol"; | ||
| import "@openzeppelin/contracts/access/Ownable.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/access/Ownable.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/OwnerData.sol
Outdated
|
|
||
| import "@openzeppelin/contracts/utils/Context.sol"; | ||
| import "@openzeppelin/contracts/access/Ownable.sol"; | ||
| import "@openzeppelin/contracts/utils/cryptography/ECDSA.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/utils/cryptography/ECDSA.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/OwnerData.sol
Outdated
| import "@openzeppelin/contracts/utils/Context.sol"; | ||
| import "@openzeppelin/contracts/access/Ownable.sol"; | ||
| import "@openzeppelin/contracts/utils/cryptography/ECDSA.sol"; | ||
| import "@openzeppelin/contracts/utils/Strings.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/utils/Strings.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/OwnerData.sol
Outdated
| import "@openzeppelin/contracts/access/Ownable.sol"; | ||
| import "@openzeppelin/contracts/utils/cryptography/ECDSA.sol"; | ||
| import "@openzeppelin/contracts/utils/Strings.sol"; | ||
| import "@openzeppelin/contracts/utils/introspection/IERC165.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/utils/introspection/IERC165.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/OwnerData.sol
Outdated
| import "@openzeppelin/contracts/utils/cryptography/ECDSA.sol"; | ||
| import "@openzeppelin/contracts/utils/Strings.sol"; | ||
| import "@openzeppelin/contracts/utils/introspection/IERC165.sol"; | ||
| import "@openzeppelin/contracts/token/ERC721/IERC721.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/token/ERC721/IERC721.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/OwnerData.sol
Outdated
| import "@openzeppelin/contracts/utils/Strings.sol"; | ||
| import "@openzeppelin/contracts/utils/introspection/IERC165.sol"; | ||
| import "@openzeppelin/contracts/token/ERC721/IERC721.sol"; | ||
| import "@openzeppelin/contracts/token/ERC1155/IERC1155.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/token/ERC1155/IERC1155.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/OwnerData.sol
Outdated
| import "@openzeppelin/contracts/utils/introspection/IERC165.sol"; | ||
| import "@openzeppelin/contracts/token/ERC721/IERC721.sol"; | ||
| import "@openzeppelin/contracts/token/ERC1155/IERC1155.sol"; | ||
| import "@openzeppelin/contracts/utils/structs/EnumerableSet.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/utils/structs/EnumerableSet.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/OwnerData.sol
Outdated
|
|
||
| string private constant SIGNED_MESSAGE = | ||
| "Authorize to write your data to the contract"; | ||
| uint256 public immutable publicToken; |
There was a problem hiding this comment.
Immutable variables name are set to be in capitalized SNAKE_CASE
tienngovan
force-pushed
the
ci/test-gas-report
branch
from
1b2a055
to
ce3095b
Compare
No description provided.